-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bump TypeScript version to 5.0 #1395
Conversation
Deploying with Cloudflare Pages
|
± Registry diff
📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.
Data
|
Codecov Report
@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
+ Coverage 64.48% 64.97% +0.48%
==========================================
Files 64 64
Lines 7569 7494 -75
Branches 1793 1761 -32
==========================================
- Hits 4881 4869 -12
+ Misses 2559 2498 -61
+ Partials 129 127 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
More of a note to future self: this PR further removes code for dragging (#644).
Description
Followup to #1394. Apparently TypeScript 5.0 changes the import sort order used by
prettier-plugin-organize-imports
, so this PR runsyarn format
to account for that. Then the other issues were our usage ofsuppressImplicitAnyIndexErrors
(see below) and incompatibility of TypeDoc (which I upgraded).Implementation strategy and design decisions
To fix the implicit
any
index errors, I made some code changes. Notable ones include:isKeyOf
function inutils/Util
which acts like thein
operator but also tells TypeScript that the key is a key of the object.valueADNums
function and replaced its usage with a call tomapShape
.Path
case fromextractPoints
because it was broken, and also removedPath
from the type signatures of the functions that callextractPoints
.Checklist