test: switch from jest to vitest #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. Data |
Deploying with
|
| Latest commit: |
fa3a10f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://073fd686.penrose-72l.pages.dev |
| Branch Preview URL: | https://vitest.penrose-72l.pages.dev |
|
I'm probably misremembering; did you say there's a lint that allows us to enforce the |
Yeah https://github.com/mysticatea/eslint-plugin-node/blob/HEAD/docs/rules/file-extension-in-import.md |
samestep
reviewed
May 21, 2023
samestep
approved these changes
May 21, 2023
There was a problem hiding this comment.
Thanks for doing this Nimo! I'm cool with merging this PR under the following caveats:
- see the minor comment I left above about
codecov.yml - we should open an issue about actually running Edgeworth tests in CI
- we should open an issue about the canvas warnings in Edgeworth tests
- we should open an issue about switching from
"moduleResolution": "node"to"moduleResolution": "node16"inoptimizer,components,edgeworth, andeditor
I no longer think we need to bother adding such a lint, because this is automatically enforced by TypeScript when we set |
This was referenced May 21, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches our testing framework from jest to vitest, which is ESM-first and much faster.
Implementation strategy and design decisions
core, we switched all imports incoreto include the.jsfile extension.coreandedgeworthto vitest and they worked well locally. However,edgeworth's tests seemed to hang the CI. Sincemainonly runs coverage oncoreanyway, this PR won't change the behavior of the test script.Examples with steps to reproduce them
Checklist
Open questions
edgeworthtests hang CI? Seems like a known issue: Vitest hangs tests, close timed out after 1000ms vitest-dev/vitest#2008canvasrelated error whenever I run tests. This is reported in Expose CanvasRenderingContext2D via thecanvaspackage vitest-dev/vitest#274 and a plugin will be needed for this. We don't actually produce diagrams in the tests, so this is really just an artifact of us doing mathjax initialization at the top level inCollectLabels.