feat: Substance as spreadsheet for timeline diagrams #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent constructor into constructor and predicate
Deploying with
|
| Latest commit: |
57b18a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a1712de.penrose-72l.pages.dev |
| Branch Preview URL: | https://timeline-tabular.penrose-72l.pages.dev |
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
Codecov Report
@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
- Coverage 64.77% 64.75% -0.02%
==========================================
Files 64 64
Lines 7515 7517 +2
Branches 1760 1760
==========================================
Hits 4868 4868
- Misses 2521 2523 +2
Partials 126 126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related #1369
This PR adds a React component that wraps around the
timelinedomain introduced in #1369. It adds a spreadsheet-like GUI for the Substance program.Screen.Recording.2023-05-22.at.12.40.03.mov
Implementation strategy and design decisions
I used
react-datasheet-gridfor the spreadsheet UI andreact-selectfor the custom dropdown cells for task categories.Examples with steps to reproduce them
An example is included in the storybook in
components, runnpx nx run components:storybookto view it.An earlier version is deployed here: https://www.cs.cmu.edu/~woden/timeline/
Checklist