feat: accurate Equation measurements
#1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0e44515
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58191c71.penrose-72l.pages.dev |
| Branch Preview URL: | https://tex-measure.penrose-72l.pages.dev |
wodeni
changed the title
Equation to match fontSize settingEquation measurements
2 tasks
wodeni
changed the title
Equation measurementsEquation measurements
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
|
Note on relative units: although I'm not sure if this has any implications to Penrose, but I am erring on the safer side of not providing support for it for now. More experimentation is needed to find out how |
|
Glancing at the registry diff, what's going on with |
samestep
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1438, resolves #1448.
Related: #842
For #340, we introduced a way to scale MathJax-generated SVGs such that
Equationshave visually-consistent sizes in a single diagram. However, #1438 points out that this scaling conversion doesn't produce labels of accurate font size. This PR does exact conversion from MathJax SVG units to pixels forwidth,height,descent, andascentof ourEquationshape.Implementation strategy and design decisions
The CSS standard defines all the units, which is implemented by the MathJax source code.
When MathJax generates an SVG, the
width,height,viewBox, andvertical-alignis computed in https://github.com/mathjax/MathJax-src/blob/a5ae9485cb7441fdd5ea59645cfbd1c12b7d53e1/ts/output/svg.ts#L239.Our implementation computes the
width,height,descent, andascentby using these values from above. See inline comments for more details.Examples with steps to reproduce them
https://tex-measure.penrose-72l.pages.dev/try/?gist=5c192c1186607e52d56b86e48ab7c3f5
https://tex-measure.penrose-72l.pages.dev/try/?gist=5e4f9cd917276e11ebaa8e798a4a62c2
Checklist
Open questions
fontSizeofEquation, only absolute units are accepted for now. The conversion to relative units such asemandptneeds font-specific information, and there's no guarantee thatTextis going to render the same way. It is possible to support them, but this is requires careful work on bothTextandEquation. Would love some help on supporting them! Given my own time constraints I'm inclined to convert existing relativefontSizes to absolute units so we can merge this PR.