feat: deduplication of mutated Substance programs in edgeworth
#1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
rjainrjain
changed the title
edgeworthedgeworth
wodeni
requested changes
Jun 13, 2023
Co-authored-by: Wode "Nimo" Ni <wn2155@columbia.edu>
Deploying with
|
| Latest commit: |
6b79d4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://025f94f7.penrose-72l.pages.dev |
| Branch Preview URL: | https://rijul-dedup.penrose-72l.pages.dev |
wodeni
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deduplication of program statements within a mutated Substance program exists in Edgeworth, but until now deduplication between mutated Substance programs themselves has not existed. This PR introduces such deduplication of programs themselves.
Implementation strategy and design decisions
We add a function
dedupSynthesizedSubstancesto SubstanceAnalysis.ts, whichreduces together the prettyprint strings of each program statement, compares the concatenated strings of each program supplied to it, and removes duplicates. Then, in thegenerateSubstancesfunction in Synthesizer.ts we rundedupSynthesizedSubstancesuntil the desired number of unique program mutations is reached.Examples with steps to reproduce them
Using the Edgeworth tool, generate 10 diagram mutations under the
lewis_0option. Checking the Substance programs of each of these mutations will show that none of the programs are duplicates, though some programs still produce visually duplicated SVGs while having different underlying Substance programs. Consider the example below:These SVGs look the same but as shown in the next image, they have different Substance programs/underlying mutations:
This PR therefore ensures the uniqueness of displayed mutated programs but not the uniqueness of their diagrams.
Checklist
Open questions
This does not resolve the problem of mutated diagrams' SVGs appearing the same despite stemming from different, unique programs.