Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async loading of solid examples in the registry #1484

Merged
merged 1 commit into from Jun 13, 2023

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Jun 13, 2023

Description

Resolves #1483.

Follows up on #1391 to re-introduce solid examples to the registry by fixing the generated imports.

Implementation strategy and design decisions

The old implementation imports solid examples no matter if the example is used. This PR wraps it around an async function to make sure it's only imported when f is invoked.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c0bdb4
Status: ✅  Deploy successful!
Preview URL: https://e3412cb8.penrose-72l.pages.dev
Branch Preview URL: https://fix-solid-registry.penrose-72l.pages.dev

View logs

@github-actions
Copy link

± Registry diff

A	solid/eigenspace.svg
A	solid/triangles.svg
A	solid/vectors.svg

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s
     |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compiling labeling optimizing rendering

If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms.

Data

                                                          0s   1s   2s   3s   4s   5s   6s   7s
                                                          |    |    |    |    |    |    |    |
set-theory-domain/tree-venn                               ▝▀▚▚
set-theory-domain/tree-tree                               ▝▀▞▖
set-theory-domain/tree-venn-3d                            ▝▀▞▄
group-theory/quaternion-multiplication-table              ▝▀▀▚▄▚▄
group-theory/quaternion-cayley-graph                      ▝▀▚▚▖
atoms-and-bonds/wet-floor                                 ▝▚▀▀▀▀▖
atoms-and-bonds/one-water-molecule                        ▝▞▖
set-theory-domain/continuousmap                           ▝▚▚
linear-algebra-domain/two-vectors-perp                    ▝▚▚
molecules/nitricacid-lewis                                ▝▀▀▀▞▀▀▖
exterior-algebra/vector-wedge                             ▝▚▚
shape-spec/all-shapes                                     ▝▚▚▄▖
shape-spec/arrowheads                                     ▝▞▖
graph-domain/textbook/sec1/fig1                           ▝▀▀▀▚▀▚
graph-domain/textbook/sec1/fig2                           ▝▀▀▀▚▀▀▖
graph-domain/textbook/sec1/fig3                           ▝▀▀▀▀▞▀▀▖
graph-domain/textbook/sec1/fig4                           ▝▀▀▀▀▞▀▚
graph-domain/textbook/sec1/fig5                           ▝▀▀▀▀▀▚▀▀▀▀▖
graph-domain/textbook/sec1/fig6                           ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
graph-domain/textbook/sec1/fig7                           ▝▀▀▞▚
graph-domain/textbook/sec1/fig8a                          ▝▀▀▀▀▀▚▀▀▀▚
graph-domain/textbook/sec1/fig8b                          ▝▀▀▀▀▞▀▀▚
graph-domain/textbook/sec1/fig9                           ▝▀▀▀▞▚
graph-domain/textbook/sec1/fig10                          ▝▀▀▚▚▄
graph-domain/textbook/sec1/fig11                          ▝▀▀▀▀▞▀▄
graph-domain/textbook/sec1/fig12                          ▝▀▀▀▀▀▞▀▀▚
graph-domain/textbook/sec1/fig13                          ▝▀▀▀▀▀▞▀▀▖
graph-domain/textbook/sec2/fig3                           ▝▀▀▀▀▀▀▀▚▀▀▀▀▀▚
graph-domain/textbook/sec2/fig4                           ▝▀▀▀▀▀▚▀▀▀▚
graph-domain/textbook/sec2/fig5                           ▝▀▀▀▀▀▀▀▀▀▚▀▀▀▀▀▚
graph-domain/textbook/sec2/fig6                           ▝▀▀▀▀▀▀▀▀▀▚▀▀▀▀▀▖
graph-domain/textbook/sec2/fig9                           ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▚
graph-domain/textbook/sec2/fig10a                         ▝▀▀▀▀▞▀▚
graph-domain/textbook/sec2/fig10b                         ▝▀▀▀▞▚
graph-domain/textbook/sec2/fig11a                         ▝▀▚▚
graph-domain/textbook/sec2/fig11b                         ▝▀▞▖
graph-domain/textbook/sec2/fig11c                         ▝▀▚▚
graph-domain/textbook/sec2/fig12                          ▝▀▚▚
graph-domain/textbook/sec2/fig13                          ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▖
graph-domain/textbook/sec2/fig14                          ▝▀▀▀▚▚▄
graph-domain/textbook/sec2/fig16b                         ▝▀▀▞▄
geometry-domain/textbook_problems/c05p13                  ▝▀▀▞▖
geometry-domain/textbook_problems/c01p01                  ▝▀▚▚
geometry-domain/textbook_problems/c03p01                  ▝▀▚▚
geometry-domain/textbook_problems/c05p01                  ▝▀▀▞▖
geometry-domain/textbook_problems/ex                      ▝▀▀▀▞▚
triangle-mesh-3d/two-triangles                            ▝▚▚
random-sampling/test                                      ▝▀▀▀▀▞▖
geometry-domain/textbook_problems/c11p12                  ▝▀▀▞▖
word-cloud/example                                        ▝▀▞▚
geometry-domain/siggraph-teaser                           ▝▀▀▚▚
minkowski-tests/maze/non-convex                           ▝▀▞▖
lagrange-bases/lagrange-bases                             ▝▚▚
hypergraph/hypergraph                                     ▝▀▀▀▞▀▀▀▀▀▀▀▀▀▚
persistent-homology/persistent-homology                   ▝▀▀▚▀▀▀▀▀▀▀▄▄
walk-on-spheres/laplace-estimator                         ▝▀▚▀▖
walk-on-spheres/poisson-estimator                         ▝▀▚▀▀▀▖
walk-on-spheres/nested-estimator                          ▝▀▀▞▀▖
walk-on-spheres/offcenter-estimator                       ▝▀▀▚▀▀▀▖
shape-distance/points-around-star                         ▝▀▀▀▞▄
shape-distance/points-around-polyline                     ▝▀▀▞▖
shape-distance/points-around-line                         ▝▀▚▚
shape-distance/lines-around-rect                          ▝▚▚
fake-3d-linear-algebra/projection                         ▝▞▖
animation/center-shrink-circle                            ▝▞▖
structural-formula/molecules/caffeine                     ▝▀▀▚▀▄
mobius/mobius                                             ▝▚▚
molecules/glutamine                                       ▝▀▚▚
matrix-ops/tests/matrix-matrix-addition                   ▝▀▀▞▖
matrix-ops/tests/matrix-matrix-division-elementwise       ▝▀▞▖
matrix-ops/tests/matrix-matrix-multiplication-elementwise ▝▀▞▖
matrix-ops/tests/matrix-matrix-multiplication             ▝▚▚
matrix-ops/tests/matrix-matrix-subtraction                ▝▚▚
matrix-ops/tests/matrix-transpose                         ▝▀▞▖
matrix-ops/tests/matrix-vector-left-multiplication        ▝▀▞▖
matrix-ops/tests/matrix-vector-right-multiplication       ▝▚▚
matrix-ops/tests/scalar-vector-division                   ▝▚▚
matrix-ops/tests/scalar-vector-left-multiplication        ▝▚▚
matrix-ops/tests/scalar-vector-right-multiplication       ▝▚▚
matrix-ops/tests/vector-vector-addition                   ▝▚▚
matrix-ops/tests/vector-vector-division-elementwise       ▝▚▚
matrix-ops/tests/vector-vector-multiplication-elementwise ▝▚▚
matrix-ops/tests/vector-vector-outerproduct               ▝▚▚
matrix-ops/tests/vector-vector-subtraction                ▝▚▚
logic-circuit-domain/half-adder                           ▝▀▞▖
curve-examples/cubic-bezier                               ▝▚▀▀▚
triangle-mesh-2d/diagrams/cotan-formula                   ▝▀▚▀▀▖
triangle-mesh-2d/diagrams/concyclic-pair                  ▝▀▚▀▖
triangle-mesh-2d/diagrams/halfedge-mesh                   ▝▀▚▚
triangle-mesh-2d/diagrams/relative-orientation            ▝▀▀▞▖
triangle-mesh-2d/diagrams/triangle-centers                ▝▀▞▖
triangle-mesh-2d/diagrams/angle-equivalence               ▝▀▀▞▀▀▚
timeline/penrose                                          ▝▀▀▚▚
graph-domain/textbook/sec5/ex32                           ▝▀▀▀▀▀▞▀▀▀▀▀▀▖
curve-examples/open-elastic-curve                         ▝▀▀▞▀▖
curve-examples/closed-elastic-curve                       ▝▀▀▞▀▚
graph-domain/other-examples/arpanet                       ▝▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▚▖
graph-domain/other-examples/nyc-subway                    ▝▀▀▀▀▀▚▀▀▀▀▖
curve-examples/blobs                                      ▝▀▀▀▀▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
curve-examples/space-curves                               ▝▀▀▀▀▀▀▚▀▀▀▀▚
geometric-queries/ray-intersect/test-group                ▝▀▀▀▀▀▀▀▀▀▚▚▖
ray-tracing/path-trace                                    ▝▀▀▞▖
ray-tracing/bidirectional                                 ▝▀▀▞▖
ray-tracing/next-event-estimation                         ▝▀▀▞▖
geometric-queries/test                                    ▝▀▚▚
geometric-queries/closest-point/test-group                ▝▀▞▖
geometric-queries/closest-point/test                      ▝▚▚
geometric-queries/closest-silhouette-point/test           ▝▚▚
geometric-queries/ray-intersect/test                      ▝▀▀▀▀▀▀▀▀▀▞▄▄
solid/eigenspace                                          ▐█
solid/triangles                                           ▐▌
solid/vectors                                             ▐▌

@wodeni wodeni marked this pull request as ready for review June 13, 2023 17:59
@samestep samestep merged commit 3234243 into main Jun 13, 2023
11 checks passed
@samestep samestep deleted the fix-solid-registry branch June 13, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor fails to render with SolidJS examples in the registry
2 participants