feat: Additional curve support #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
184289d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41b05148.penrose-72l.pages.dev |
| Branch Preview URL: | https://brownian-motion.penrose-72l.pages.dev |
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
liangyiliang
approved these changes
Jun 23, 2023
wodeni
approved these changes
Jun 23, 2023
|
Merged—thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on support for curves/paths in Style by adding several functions to
Functions.ts:interpolatingSpline()— provides path data for an (open or closed) Catmull-Rom spline interpolating a given set of points, with optionaltensionvalue. This method provides an easy way to draw a smooth curve through a list of points without having to explicitly think about tangents.diffusionProcess()— provides a way to generate a common type of "random" curve, namely, those that arise from Brownian motion. This functionality mirrors functionality provided by other packages—for instance, Mathematica provides a similar collection of functions under the heading Stochastic Differential Equation Processes. I decided against simply calling this methodrandomCurve()which, while a bit more accessible, we might want to reserve for other notions of "random curve."firstPoint()/lastPoint()— readable convenience methods to access the first and last point of a list of points in Style. Much like our other nomenclature choices, these methods are named as a readable alternative to expressions likemyList[0]ormyList[ length(myList) - 1 ](which we may or may not even currently support).averagePoint()— returns the average (mean) of all points in a list. This function extends existing list processing functionality likesumVectors(),maxList(), andminList()(which is heavily used incollectstatements). It could perhaps be emulated in Style via something likesumVectors(list)/length(list), but again, a convenience function provides more readable code; it's also not clear right now that we provide a mechanism for determining list length outside ofcollectstatements (the plainlength()function currently has an extremely special functionality—measuring the length of aLineshape—which should probably be renamed).In general, more sophisticated list processing in Style, and the ability to interpret lists as various kinds of curves seems pretty essential for real diagramming. The most significant functionality missing from this PR is the ability to concatenate multiple paths to generate another path—e.g., using several curves from different parts of a diagram to make a single region boundary of a shaded shape. This PR can be viewed as sort of "dipping our toes" into the waters of more real-world path manipulation.
Examples
The features above are demonstrated/tested using two new examples (shown above):
curve-examples/catmull-rom: demonstrates theinterpolatingSpline()function, including several parameter values fortension.stochastic-process: demonstrates thediffusionProcess(),lastPoint(), andaveragePoint()functions. This example also shows compositionality of the PR functions—here for instance the point list generated bydiffusionProcess()is fed tointerpolatingSpline()to get a smoother curve.Implementation
Some methods were refactors as local computation functions (rather than only being exported to Style), which also helps make them usable through the API. In particular, generation of normally-distributed random numbers, construction of Catmull-Rom splines, and generation of stochastic curves.