feat: error and warning markings in IDE editor #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
Deploying with
|
| Latest commit: |
801aa99
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://155842a1.penrose-72l.pages.dev |
| Branch Preview URL: | https://squig.penrose-72l.pages.dev |
wodeni
approved these changes
Jun 29, 2023
| @@ -608,6 +612,246 @@ canvas { | |||
| } | |||
| }; | |||
|
|
|||
| export const errLocs = ( | |||
There was a problem hiding this comment.
Another way would be to add this to an umbrella type so every error is required to identify the offending source location. This is also fine, but the downside is yet another place to update when a new error is added.
| range: SourceRange; | ||
| }; | ||
|
|
||
| export const toErrorLoc = (node: { |
There was a problem hiding this comment.
Is this function only renaming and grouping some values? Looks like you had to do some work when feeding them to monaco anyway. Why is this step necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since many types of warnings and errors include source location information, we can utilize these information to mark them in the IDE editor.
Implementation strategy and design decisions
errLocs, that extracts the location information (which file, which row, which column) from each error and warning, exceptStyleErrorList.StyleErrorListessentially stores multiple Style errors, so we handle them specially.Checklist