feat: cropping picks smaller viewbox in gallery and editor
#1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
Deploying with
|
| Latest commit: |
a8cdf0a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2778a9e4.penrose-72l.pages.dev |
| Branch Preview URL: | https://rijul-crop-by-area.penrose-72l.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the problem of diagram previews being cropped to the tightest bounding box even when the intended view box is zoomed in on a portion of the total shapes, which makes some previews look wholly unlike the actual diagrams in the gallery and the editor.
We introduce a check to compare the areas of (1) the existing view box and (2) the tightest bounding box of all shapes, and set the SVG
viewBoxto the smaller of the two.Implementation strategy and design decisions
Since this is done after the SVGs have been produced, we parse the widths and heights of the
viewBoxandcroppedViewBoxstrings from these SVGs to calculate the area. We only set theviewBoxto the values incroppedViewBoxif the area of the latter is smaller than the former.Examples with steps to reproduce them
Here is a screenshot of the previously badly cropped diagram in the gallery (Brownian Motion Absorbed at Boundary), which is now fixed:
And here it is in the editor:
Checklist