fix: bounding boxes and points for rotated rects #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
Deploying with
|
| Latest commit: |
7e48c61
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60ad42c0.penrose-72l.pages.dev |
| Branch Preview URL: | https://bboxrot.penrose-72l.pages.dev |
wodeni
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1595.
The way we handle rotated rectlike shapes has a few problems.
Rectangleshape, thebboxFromRectfunction computes the bounding box. But it ignores therotationfield. There already exists a functionbboxFromRotatedRect(which is used to handle other rect-like shapes such asTextandImage) which we can use.bboxFromRotatedRectis also implemented incorrectly since it uses the wrong anchor for rotation. Rotation of rectlike shapes is rendered with respect to the center of the shape, butbboxFromRotatedRectuses the top-left corner as the anchor which is inconsistent.rectPtsuses the same internal algorithm asbboxFromRotatedRect, which has the same error.See example at code:
Implementation strategy and design decisions
I changed three things.
rectPtsnow runs the correct algorithm that bases its rotation on the center of the shape.bboxFromRotatedRectnow runsrectPtsand constructs a bounding box from these points.bboxFromRectnow callsbboxFromRotatedRect.Examples with steps to reproduce them
https://bboxrot.penrose-72l.pages.dev/try/?gist=d24def0664273563a9d5360289b6b6d7
The example above now behaves correctly.
Checklist