-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React dependencies and retrofit clients (IDE and automator) #388
Conversation
…se ttsc (tsc with transformers) for build-lib
Thanks for doing this! I took a quick look but am not super familiar with ts internals so can't say much about that. Is this ready to merge? Also, +1 to |
Still need to address some issues listed in the open questions section. The timeline depends on how soon we want the automator and IDE back. |
…use import statement outside a module' errors
…ng issues to be resolved
…tly now with two examples
Description
Related issues: #336
Our dependencies
create-react-app-ts
andtslint
are both deprecated. This PR moves our web version tocreate-react-app
andeslint
, which support TypeScript now.The new TypeScript runtime also includes some breaking changes that affect both the automator and IDE. These two projects depend on
penrose-web
and use its API functions. This PR also aims to retrofit both modules to the new API.Implementation strategy and design decisions
penrose-web
, the IDE fails to resolve modules of it. I used ttsc (tsc
with transformers) to transform paths in the compiled JavaScript files.build-lib
to bypass CRA limitations (e.g.noEmit
).tslog
for loggingExamples with steps to reproduce them
penrose-web
and the IDE by following the wikinpx ts-node ./index.tsx "batch" "substanceLibrary.json" "styleLibrary.json" "elementLibrary.json" "out"
Open questions
Questions that require more discussion or to be addressed in future development:
react-renderer
: I'm thinkingpenrose-web