Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow vectors to be multiplied by a scalar #650

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

Mystic5pirit
Copy link
Contributor

Related issue/PR: #581

Allows vectors to be multiplied by a scalar

@Mystic5pirit Mystic5pirit changed the title Fixes Issue 581, allowing vectors to be multiplied by a scalar fix: allow vectors to be multiplied by a scalar Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #650 (1d6f59a) into main (2d81a55) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   66.57%   66.54%   -0.03%     
==========================================
  Files          44       44              
  Lines        7103     7106       +3     
  Branches     1336     1337       +1     
==========================================
  Hits         4729     4729              
- Misses       2365     2368       +3     
  Partials        9        9              
Impacted Files Coverage Δ
packages/core/src/engine/Evaluator.ts 63.28% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d81a55...1d6f59a. Read the comment docs.

@wodeni wodeni changed the title fix: allow vectors to be multiplied by a scalar fix (#581): allow vectors to be multiplied by a scalar Sep 24, 2021
@wodeni wodeni changed the title fix (#581): allow vectors to be multiplied by a scalar fix: allow vectors to be multiplied by a scalar Sep 24, 2021
@wodeni
Copy link
Member

wodeni commented Sep 24, 2021

Awesome. Thanks for fixing this, @Mystic5pirit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants