Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Circle CI OOM error when building #651 #655

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

cmumatt
Copy link
Contributor

@cmumatt cmumatt commented Oct 1, 2021

Description

Related issue: #651

Build sequentially in CI to avoid OOM error caused by default build parallelization in Circle CI medium Docker instance.

Another fix option discussed: change the resource type on the Circle CI Docker instance to one with more RAM. Removing parallelization allows us to avoid switching resource types and CI plans without much difference in build time.

Implementation strategy and design decisions

Instruct lerna to limit build concurrency to 1 vs. lerna's default, which is based on the underlying CPU & core count.

Examples with steps to reproduce them

Repeatedly re-run build in CircleCI. Observe consistently successful build vs. previous intermittent failures.

Checklist

  • I have commented my code where appropriate, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally using yarn test
  • I ran yarn docs and there were no errors when generating the HTML site
  • My code follows the style guidelines of this project (e.g.: no ESLint warnings)

Open questions

At a later point, provisioning more build resources and re-introducing build parallelization may be prudent. But right now, our build times are short and we do not have a large number of packages to parallelize.

@cmumatt cmumatt requested a review from wodeni October 1, 2021 14:57
@wodeni wodeni merged commit a50ccae into penrose:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants