Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename repel to notTooClose #300 #662

Merged
merged 1 commit into from Dec 6, 2022
Merged

chore: rename repel to notTooClose #300 #662

merged 1 commit into from Dec 6, 2022

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Oct 12, 2021

Description

Closes #300

Implementation strategy and design decisions

  • Used "Find in files" in VSCode to replace all instances.

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #662 (315705d) into main (f374f1a) will increase coverage by 0.04%.
The diff coverage is 23.68%.

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   64.52%   64.56%   +0.04%     
==========================================
  Files          59       59              
  Lines        7676     7677       +1     
  Branches     1719     1714       -5     
==========================================
+ Hits         4953     4957       +4     
+ Misses       2620     2617       -3     
  Partials      103      103              
Impacted Files Coverage Δ
packages/core/src/contrib/Utils.ts 45.76% <ø> (+4.58%) ⬆️
packages/core/src/engine/Optimizer.ts 80.80% <ø> (ø)
packages/core/src/utils/CollectLabels.ts 79.18% <ø> (ø)
packages/core/src/contrib/Functions.ts 28.95% <6.66%> (-0.62%) ⬇️
packages/core/src/contrib/ConstraintsUtils.ts 77.84% <7.14%> (-6.88%) ⬇️
packages/core/src/contrib/Constraints.ts 85.82% <75.00%> (+2.74%) ⬆️
packages/core/src/contrib/Objectives.ts 20.58% <100.00%> (+2.16%) ⬆️
packages/core/src/engine/Autodiff.ts 85.07% <0.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wodeni
Copy link
Member Author

wodeni commented Oct 12, 2021

Also need to update the tutorial if it used repel.

@wodeni wodeni changed the title chore: rename repel to notTooClose #300 chore: rename repel to notTooClose #300 Oct 13, 2021
@wodeni wodeni self-assigned this Oct 13, 2021
Copy link
Collaborator

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward 👍

Also need to update the tutorial if it used repel.

Could you open a PR or issue for this in the tutorials repo, before merging this one? Just to make sure it doesn't slip through the cracks

@wodeni
Copy link
Member Author

wodeni commented Oct 13, 2021

Could you open a PR or issue for this in the tutorials repo, before merging this one? Just to make sure it doesn't slip through the cracks

Good point. Although penrose/tutorials doesn't seem to contain everything. Not super sure about how it's deployed and where the contents are stored tbh, cc: @miatang13 @maxkrieger?

@maxkrieger
Copy link
Member

Could you open a PR or issue for this in the tutorials repo, before merging this one? Just to make sure it doesn't slip through the cracks

Good point. Although penrose/tutorials doesn't seem to contain everything. Not super sure about how it's deployed and where the contents are stored tbh, cc: @miatang13 @maxkrieger?

Some of it might still be on gitbooks

@wodeni
Copy link
Member Author

wodeni commented Oct 13, 2021

Some of it might still be on gitbooks

Umm does that mean the source files are not in this GH org at all? Just somewhere on the gitbooks storage?

Just found that I have access to the gitbooks lib :P

@wodeni
Copy link
Member Author

wodeni commented Oct 15, 2021

Just opened a change request on gitbook. Not sure who has access to review and merge it though. Maybe @miatang13 or @maxkrieger?

@maxkrieger
Copy link
Member

@joshsunshine does

@wodeni wodeni closed this Jan 14, 2022
@wodeni wodeni deleted the rename-repel branch May 24, 2022 18:37
@wodeni wodeni restored the rename-repel branch December 6, 2022 15:49
@wodeni wodeni reopened this Dec 6, 2022
@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 6, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 315705d
Status: ✅  Deploy successful!
Preview URL: https://f12fd7c1.penrose-72l.pages.dev
Branch Preview URL: https://rename-repel.penrose-72l.pages.dev

View logs

@samestep
Copy link
Collaborator

samestep commented Dec 6, 2022

We changed repel from a constraint to an objective in #751.

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                        0s   1s   2s   3s   4s   5s   6s   7s   8s   9s  10s  11s  12s  13s  14s  15s  16s  17s  18s  19s  20s  21s  22s  23s  24s  25s  26s  27s  28s  29s  30s  31s  32s  33s  34s  35s  36s  37s  38s  39s  40s  41s  42s  43s  44s  45s  46s  47s  48s  49s  50s  51s  52s  53s  54s  55s  56s  57s  58s  59s  60s  61s  62s  63s  64s  65s  66s  67s  68s  69s  70s  71s  72s  73s  74s  75s  76s  77s  78s  79s  80s  81s  82s  83s  84s  85s  86s  87s  88s  89s  90s  91s  92s  93s  94s  95s  96s  97s  98s  99s 100s
                                        |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra    ▝▚▚
allShapes-dashedShapes                  ▝▞▖
arrowheads-arrowheads                   ▝▀▞▖
circle-example-euclidean                ▝▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
collinear-euclidean                     ▝▀▀▞▀▀▚
congruent-triangles-euclidean           ▝▀▀▀▀▀▀▀▀▞▚
continuousmap-continuousmap             ▝▀▞▖
hypergraph-hypergraph                   ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
incenter-triangle-euclidean             ▝▀▀▀▞▀▀▀▀▀▀▀▀▀▖
lagrange-bases-lagrange-bases           ▝▀▞▖
midsegment-triangles-euclidean          ▝▀▀▀▞▖
non-convex-non-convex                   ▝▀▀▀▚▀▀▀▀▚
one-water-molecule-atoms-and-bonds      ▝▚▚
parallel-lines-euclidean                ▝▀▀▞▀▀▀▀▀▀▀▀▚
persistent-homology-persistent-homology ▝▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▘⋯
points-around-line-shape-distance       ▝▀▀▀▀▀▚▚
points-around-polyline-shape-distance   ▝▀▀▀▀▀▀▀▀▀▀▀▞▀▚
points-around-star-shape-distance       ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▀▚
siggraph-teaser-euclidean-teaser        ▝▀▀▀▀▞▀▀▖
small-graph-disjoint-rect-line-horiz    ▝▀▀▀▀▀▀▀▚▀▖
small-graph-disjoint-rects              ▝▀▀▄▚
small-graph-disjoint-rects-large-canvas ▝▀▞▖
small-graph-disjoint-rects-small-canvas ▝▀▞▖
tree-tree                               ▝▀▚▚
tree-venn                               ▝▀▀▚▞▀▖
tree-venn-3d                            ▝▀▀▀▚▀▀▚▄
two-vectors-perp-vectors-dashed         ▝▀▞▖
vector-wedge-exterior-algebra           ▝▀▚▚
wet-floor-atoms-and-bonds               ▝▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
wos-laplace-estimator-walk-on-spheres   ▝▀▀▀▚▀▀▀▖
wos-nested-estimator-walk-on-spheres    ▝▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
wos-offcenter-estimator-walk-on-spheres ▝▀▀▀▚▀▀▀▀▖
wos-poisson-estimator-walk-on-spheres   ▝▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖

@samestep samestep merged commit ac0526b into main Dec 6, 2022
@samestep samestep deleted the rename-repel branch December 6, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename repel (and other "operational" encourage statements)
3 participants