Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @penrose/panels to the monorepo #681

Merged
merged 6 commits into from Nov 9, 2021
Merged

feat: add @penrose/panels to the monorepo #681

merged 6 commits into from Nov 9, 2021

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Nov 5, 2021

Description

Related issue/PR: #659, #671

This PR migrates the IDE into our monorepo.

Implementation strategy and design decisions

  • Update the usage of stepUntilConvergence to account for the API change on error handling
  • Drop CRA and switch to ESBuild

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally using yarn test
  • I ran yarn docs and there were no errors when generating the HTML site
  • My code follows the style guidelines of this project (e.g.: no ESLint warnings)

Open questions

  • CRA doesn't seem to work well with ESBuild outputs. For instance, if I run yarn start in panels, CRA complains about Module parse failed: Unexpected token (749:18). Haven't investigated this further, but I'm assuming this is the same issue as I saw in feat: React component library #671, i.e. ES6 operators not supported by CRA (?).

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #681 (e37b9fc) into main (d65ac8d) will not change coverage.
The diff coverage is n/a.

❗ Current head e37b9fc differs from pull request most recent head e97af8b. Consider uploading reports for the commit e97af8b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files          44       44           
  Lines        7105     7105           
  Branches     1335     1335           
=======================================
  Hits         4747     4747           
  Misses       2349     2349           
  Partials        9        9           
Impacted Files Coverage Δ
packages/core/src/index.ts 77.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65ac8d...e97af8b. Read the comment docs.

@wodeni wodeni merged commit 24d5bd0 into main Nov 9, 2021
@wodeni wodeni deleted the migrate-panes branch November 9, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant