Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: determine pointer-event for dragging based on shape kind #686

Merged
merged 2 commits into from Nov 12, 2021

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Nov 12, 2021

Description

For line-like shapes (e.g. Line), RenderInteractive set the pointer-event attribute to bounding-box. Changing it such that we use isRectlike and isLinelike to determine the correct value. For instance, pointer-event: visibleStroke works better for line-like shapes.

@wodeni wodeni changed the title fix: determine pointer-event for dragging based on shape kind fix: determine pointer-event for dragging based on shape kind Nov 12, 2021
@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 12, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b76fcbb
Status: ✅  Deploy successful!
Preview URL: https://11f72bac.penrose-panes.pages.dev

View logs

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #686 (b76fcbb) into main (bb0737e) will decrease coverage by 0.04%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   66.82%   66.77%   -0.05%     
==========================================
  Files          44       44              
  Lines        7107     7116       +9     
  Branches     1330     1332       +2     
==========================================
+ Hits         4749     4752       +3     
- Misses       2349     2355       +6     
  Partials        9        9              
Impacted Files Coverage Δ
packages/core/src/renderer/Renderer.ts 32.43% <12.50%> (-1.90%) ⬇️
packages/core/src/contrib/Constraints.ts 62.78% <100.00%> (-0.65%) ⬇️
packages/core/src/contrib/Functions.ts 39.03% <100.00%> (+0.22%) ⬆️
packages/core/src/renderer/ShapeDef.ts 82.81% <100.00%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0737e...b76fcbb. Read the comment docs.

@wodeni wodeni merged commit c3c0cc3 into main Nov 12, 2021
@wodeni wodeni deleted the fix-pointer-event branch November 12, 2021 17:33
wodeni added a commit that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant