Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Domain syntax highlighting #691

Merged
merged 2 commits into from Nov 12, 2021
Merged

feat: Domain syntax highlighting #691

merged 2 commits into from Nov 12, 2021

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Nov 12, 2021

Description

Related issue/PR: #659

@penrose/panels doesn't highlight Domain programs. This PR adds language configuration for the Domain language.

Implementation strategy and design decisions

  • Separate languageConfigs into individual modules and add DomainConfig.
  • Fix small issue with errors related to @brackets

Examples with steps to reproduce them

Run yarn start:ide at the top-level and write a Domain program!

image

Open questions

  • I noticed the Style config hard code a lot of things. Perhaps we can export the keywords, type annotations, or even constraint/computation dicts from core to fix this.

@wodeni wodeni self-assigned this Nov 12, 2021
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e75a0d
Status: ✅  Deploy successful!
Preview URL: https://6cb1e01d.penrose-panes.pages.dev

View logs

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #691 (8e75a0d) into main (e11c4e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files          44       44           
  Lines        7115     7115           
  Branches     1332     1332           
=======================================
  Hits         4752     4752           
  Misses       2354     2354           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11c4e0...8e75a0d. Read the comment docs.

@wodeni wodeni merged commit d9fdcb5 into main Nov 12, 2021
@wodeni wodeni deleted the domain-highlight branch November 12, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant