Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Document the fact that rot90 is counterclockwise #711

Merged
merged 1 commit into from Dec 16, 2021

Conversation

samestep
Copy link
Collaborator

Description

Previously the documentation for rot90 said that it rotates a point/vector clockwise. As far as I can tell, this is incorrect, so this PR modifies the documentation to say that it rotates counterclockwise.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally using yarn test
  • I ran yarn docs and there were no errors when generating the HTML site
  • My code follows the style guidelines of this project (e.g.: no ESLint warnings)

@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 10, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0567cc9
Status: ✅  Deploy successful!
Preview URL: https://80bec239.penrose-panes.pages.dev

View logs

@samestep samestep changed the title Document the fact that rot90 is counterclockwise fix: Document the fact that rot90 is counterclockwise Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #711 (0567cc9) into main (3a0d6ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files          44       44           
  Lines        7144     7144           
  Branches     1343     1343           
=======================================
  Hits         4779     4779           
  Misses       2356     2356           
  Partials        9        9           
Impacted Files Coverage Δ
packages/core/src/contrib/Functions.ts 39.56% <ø> (ø)
packages/core/src/engine/Autodiff.ts 73.88% <ø> (ø)
packages/core/src/utils/Util.ts 24.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0d6ac...0567cc9. Read the comment docs.

@cmumatt cmumatt merged commit c0a01c8 into main Dec 16, 2021
@samestep samestep deleted the rot90-is-counterclockwise branch December 30, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants