refactor: Retype ASTs

[samestep]

Description

This PR adds types to packages/core/src/parser/ParserUtil.ts to get rid of all warnings in that file. Doing this required a few additional changes beyond just adding types to ParserUtil:

• new SourceRange type in types/ast
• slight change to the type predicate used in rangeOf
• rewrite of tokenEnd to fix bugs
• new test for tokenEnd

and also a substantial reworking of our AST types:

• every AST node type is now generic in whether or not it extends SourceRange
• types/ast now provides A and C types to put in that generic slot, corresponding to "abstract" or "concrete"
• every usage of those types has been updated to provide that generic type parameter
• most ended up being A, because even in our compilers we generate a lot of synthetic nodes
• for other types holding nodes, everything that could be C was made C, but some were forced to be A due to above
• error types use A instead of C just for convenience
• this rewrite found a few missing nodeType and children fields in synthetic nodes, which were fixed

Checklist

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new ESLint warnings

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	5dc6030
Status:	✅  Deploy successful!
Preview URL:	https://84b1286e.penrose-panes.pages.dev

View logs

[samestep]

Oh... the build is failing mostly because all the parsers pass ASTNodes to these functions instead of ConcreteNodes, so their types say that the start and end fields are optional; I don't know how to fix this so I'm turning this PR back to a draft for now, but @wodeni if you have any ideas of how to deal with this then let me know.

[codecov]

Codecov Report

Merging #739 (5dc6030) into main (7d5538b) will increase coverage by 0.00%.
The diff coverage is 79.48%.

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   68.85%   68.86%           
=======================================
  Files          61       61           
  Lines        7725     7765   +40     
  Branches     1454     1454           
=======================================
+ Hits         5319     5347   +28     
- Misses       2393     2405   +12     
  Partials       13       13           

Impacted Files	Coverage Δ
packages/core/src/renderer/Resample.ts	23.63% <0.00%> (-0.44%)	⬇️
packages/core/src/synthesis/Mutation.ts	22.97% <16.66%> (ø)
packages/core/src/synthesis/Synthesizer.ts	20.32% <18.86%> (-0.39%)	⬇️
packages/core/src/engine/PropagateUpdate.ts	36.84% <66.66%> (ø)
packages/core/src/analysis/SubstanceAnalysis.ts	53.47% <75.60%> (+0.91%)	⬆️
packages/core/src/utils/Error.ts	34.49% <78.57%> (ø)
packages/core/src/engine/Evaluator.ts	64.57% <85.71%> (ø)
packages/core/src/synthesis/Search.ts	88.09% <88.46%> (-0.24%)	⬇️
packages/core/src/parser/ParserUtil.ts	96.96% <91.66%> (-1.45%)	⬇️
packages/core/src/engine/EngineUtils.ts	69.26% <95.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5538b...5dc6030. Read the comment docs.