fix: use empty string as the default label and check autolabel statements #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue/PR: #752
When
NoLabel
is used or no labeling statements exist for a Substance variable, the current system doesn't insert alabel
field for that variable in theTranslation
. This often causes expected errors. In this PR, we change the default to empty strings as default labels even when there's no labeling statements.Implementation strategy and design decisions
AutoLabel None
should define an empty label #752 also uncovers a bug in the Substance checker: we didn't check the variables of statements likeAutoLabel A, B, C
. Added the checking in the Substance checker.""
labels for every variable and insert""
forNoLabel
statementsExamples with steps to reproduce them