New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve performance of Autodiff #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 65.72% 65.22% -0.51%
==========================================
Files 59 59
Lines 7980 8040 +60
Branches 1405 1413 +8
==========================================
- Hits 5245 5244 -1
- Misses 2726 2787 +61
Partials 9 9
Continue to review full report at Codecov.
|
Deploying with Cloudflare Pages
|
wodeni
approved these changes
Jan 10, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autodiff gradient tests ran during every diagram generation so this PR turns those tests off. This PR also converts the recursive graph traversal into iterative traversals to avoid stack overflows. Finally, this PR combines multiple graph traversals to clear the cache into a single traversal.
Related issue/PR: # (issue/PR)
#652
This issue is not complete, but the simple changes do improve the performance of Autodiff.
Checklist
yarn test
yarn docs
and there were no errors when generating the HTML siteOpen questions
Questions that require more discussion or to be addressed in future development: