Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: two changes to browser-ui to adapt to the new navigation methods #807

Merged
merged 1 commit into from Jan 10, 2022

Conversation

joshsunshine
Copy link
Member

@joshsunshine joshsunshine commented Jan 10, 2022

Description

Related issue/PR: # (issue/PR)

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Implementation strategy and design decisions

Include a high-level summary of the implementation strategy and list important design decisions made, if any.

Examples with steps to reproduce them

Checklist

This is a two-line fix to restore browser-ui after changes to graph navigation methods.

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code follows the style guidelines of this project (e.g.: no ESLint warnings)

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #807 (d2d86d4) into main (8bca6db) will not change coverage.
The diff coverage is n/a.

❗ Current head d2d86d4 differs from pull request most recent head ce406a4. Consider uploading reports for the commit ce406a4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   65.42%   65.42%           
=======================================
  Files          59       59           
  Lines        7979     7979           
  Branches     1410     1410           
=======================================
  Hits         5220     5220           
  Misses       2750     2750           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bca6db...ce406a4. Read the comment docs.

@joshsunshine joshsunshine merged commit 4a94cac into main Jan 10, 2022
@wodeni wodeni deleted the fix-graph-utils branch May 24, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant