Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a proof-of-concept for annotating Penrose diagrams with audio. Audio annotations are potentially useful for increasing the accessibility of diagrams for, e.g., the blind or partially sighted.
It also updates the renderer to specify the
xmlns
string as the first attribute in the globalsvg
tag, which was needed to get the example to work. (It seems writing this attribute first is required for some browsers to provide the correct behavior for certain SVG features.)Checklist
Open questions
See
README.md
for some comments about features that would need to be supported in order to make sound a first-class entity in Penrose diagrams, namely, referencing external audio files (which is related to the ongoing question of how to reference external SVG files), and inserting the appropriate definitions at the top of the SVG.