Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enforce no ESLint errors #830

Merged
merged 4 commits into from Jan 12, 2022
Merged

ci: Enforce no ESLint errors #830

merged 4 commits into from Jan 12, 2022

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Jan 12, 2022

Description

This PR does the following:

  • Add a lint script to our root package.json which runs lint in any packages that include it (currently just core and browser-ui, both of which just run ESLint)
  • Add a lint job to our Build workflow in CI which runs yarn lint
  • Eliminate all ESLint errors, so the lint job passes

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings

Open questions

  • Get rid of ESLint warnings too

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #830 (0aa6873) into main (fb7783d) will increase coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   67.86%   68.05%   +0.18%     
==========================================
  Files          61       61              
  Lines        7640     7706      +66     
  Branches     1375     1387      +12     
==========================================
+ Hits         5185     5244      +59     
- Misses       2445     2451       +6     
- Partials       10       11       +1     
Impacted Files Coverage Δ
packages/core/src/engine/EngineUtils.ts 69.26% <0.00%> (-0.34%) ⬇️
packages/core/src/engine/Evaluator.ts 64.57% <0.00%> (-0.18%) ⬇️
packages/core/src/renderer/Staging.ts 12.50% <0.00%> (ø)
packages/core/src/utils/Error.ts 34.49% <0.00%> (-0.16%) ⬇️
packages/core/src/renderer/AttrHelper.ts 86.92% <0.00%> (-0.22%) ⬇️
packages/core/src/shapes/Text.ts 100.00% <0.00%> (ø)
packages/core/src/renderer/Text.ts 100.00% <0.00%> (ø)
packages/core/src/compiler/Style.ts 86.52% <0.00%> (+0.01%) ⬆️
packages/core/src/renderer/Label.ts 87.09% <0.00%> (+1.38%) ⬆️
packages/core/src/utils/CollectLabels.ts 90.72% <0.00%> (+3.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7783d...0aa6873. Read the comment docs.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 12, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 343ad80
Status:🚫  Build failed.

View logs

@samestep samestep changed the title ci: Enforce ESLint ci: Enforce no ESLint errors Jan 12, 2022
@samestep samestep marked this pull request as ready for review January 12, 2022 19:22
@samestep samestep merged commit d843946 into main Jan 12, 2022
@samestep samestep deleted the eslint-ci branch January 12, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant