Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: maximal and minimal objectives #852

Merged
merged 1 commit into from
Jan 15, 2022
Merged

feat: maximal and minimal objectives #852

merged 1 commit into from
Jan 15, 2022

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Jan 14, 2022

Description

@keenancrane mentioned a repeated pattern of encourage equal(<some value>, 0). After some discussion, we decided to add maximal and minimal for sending single values to inf or -inf. This is similar to saying "minimize" and "maximize" in optimization problems.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #852 (c9f677f) into main (b20400a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head c9f677f differs from pull request most recent head ad99421. Consider uploading reports for the commit ad99421 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   68.25%   68.23%   -0.02%     
==========================================
  Files          62       62              
  Lines        8058     8060       +2     
  Branches     1812     1812              
==========================================
  Hits         5500     5500              
- Misses       2478     2480       +2     
  Partials       80       80              
Impacted Files Coverage Δ
packages/core/src/contrib/Objectives.ts 51.85% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20400a...ad99421. Read the comment docs.

@netlify
Copy link

netlify bot commented Jan 14, 2022

❌ Deploy Preview for penrose-saurus failed.

🔨 Explore the source changes: ad99421

🔍 Inspect the deploy log: https://app.netlify.com/sites/penrose-saurus/deploys/61e1ffb32b6bcd0007da80ef

@wodeni wodeni merged commit c402b7f into main Jan 15, 2022
@wodeni wodeni deleted the max-min-objs branch January 15, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant