Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement convex partitioning #877

Merged
merged 11 commits into from Feb 16, 2022
Merged

feat: Implement convex partitioning #877

merged 11 commits into from Feb 16, 2022

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Feb 3, 2022

Description

This PR implements convexPartitions in contrib/Minkowski using poly-decomp.js.

Gist with an SVG visualizing the test case added in this PR: https://gist.github.com/samestep/288e63d2bdd2279d55585d32a4676c9e

SVG

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #877 (c4f2526) into main (6b324e4) will increase coverage by 0.04%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   67.39%   67.43%   +0.04%     
==========================================
  Files          62       62              
  Lines        8164     8181      +17     
  Branches     1768     1771       +3     
==========================================
+ Hits         5502     5517      +15     
- Misses       2655     2657       +2     
  Partials        7        7              
Impacted Files Coverage Δ
packages/core/src/contrib/Minkowski.ts 97.56% <89.47%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b324e4...c4f2526. Read the comment docs.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 3, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c4f2526
Status: ✅  Deploy successful!
Preview URL: https://9875ae97.penrose-panes.pages.dev

View logs

@samestep samestep marked this pull request as ready for review February 15, 2022 21:23
@samestep samestep changed the title feat: Add convex partitioning algorithm feat: Implement convex partitioning Feb 15, 2022
Copy link
Contributor

@jiriminarcik jiriminarcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and simple solution. :) I want to do some more end-to-end tests and try it on some examples. Will do it later in a separate PR.

@samestep samestep merged commit d7968fb into main Feb 16, 2022
@samestep samestep deleted the convex-partitions branch February 16, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants