Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resample button in panes #881

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: Resample button in panes #881

merged 1 commit into from
Feb 8, 2022

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Feb 8, 2022

Description

#864 changed the semantics of resample so now it only resets the diagram using its current seeds instead of resampling with new seeds. The same PR updated browser-ui so that the "resample" button in the UI also generates new seeds before calling resample, but did not update panes to do the same. This PR fixes that bug.

Examples with steps to reproduce them

Open any diagram in panes, click the resample button and see whether it changes.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8947eb4
Status: ✅  Deploy successful!
Preview URL: https://d454527e.penrose-panes.pages.dev

View logs

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #881 (8947eb4) into main (033a259) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files          62       62           
  Lines        8206     8206           
  Branches     1774     1774           
=======================================
  Hits         5540     5540           
  Misses       2659     2659           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033a259...8947eb4. Read the comment docs.

@samestep samestep changed the title fix: Resample button in panes fix: Fix resample button in panes Feb 8, 2022
@samestep samestep changed the title fix: Fix resample button in panes fix: Resample button in panes Feb 8, 2022
@samestep samestep changed the title fix: Resample button in panes fix: Fix resample button in panes Feb 8, 2022
@samestep samestep changed the title fix: Fix resample button in panes fix: Resample button in panes Feb 8, 2022
@samestep samestep merged commit c1626cf into main Feb 8, 2022
@samestep samestep deleted the fix-panes-resample branch February 8, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant