Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Organize imports via Prettier #883

Merged
merged 2 commits into from Feb 8, 2022
Merged

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Feb 8, 2022

This PR adds https://github.com/simonhaenisch/prettier-plugin-organize-imports to the repo:

This is the same as using the "Organize Imports" action in VS Code.

CI on the first commit to this PR shows that disorganized imports now get caught automatically: https://github.com/penrose/penrose/runs/5113952369?check_suite_focus=true

@samestep samestep requested a review from wodeni February 8, 2022 18:09
@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 8, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f27301
Status: ✅  Deploy successful!
Preview URL: https://34396d18.penrose-panes.pages.dev

View logs

Copy link
Member

@wodeni wodeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #883 (b5e3b03) into main (c1626cf) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b5e3b03 differs from pull request most recent head 5f27301. Consider uploading reports for the commit 5f27301 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files          62       62           
  Lines        8206     8206           
  Branches     1774     1774           
=======================================
  Hits         5540     5540           
  Misses       2659     2659           
  Partials        7        7           
Impacted Files Coverage Δ
packages/core/src/analysis/SubstanceAnalysis.ts 49.68% <ø> (ø)
packages/core/src/compiler/Substance.ts 90.93% <ø> (ø)
packages/core/src/contrib/Minkowski.ts 100.00% <ø> (ø)
packages/core/src/engine/BBox.ts 84.61% <ø> (ø)
packages/core/src/engine/Evaluator.ts 61.67% <ø> (ø)
packages/core/src/engine/PropagateUpdate.ts 31.81% <ø> (ø)
packages/core/src/parser/ParserUtil.ts 97.01% <ø> (ø)
packages/core/src/renderer/Circle.ts 100.00% <ø> (ø)
packages/core/src/renderer/Ellipse.ts 27.27% <ø> (ø)
packages/core/src/renderer/Image.ts 84.37% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1626cf...5f27301. Read the comment docs.

@samestep samestep merged commit 4b749ae into main Feb 8, 2022
@samestep samestep deleted the prettier-organize-imports branch February 8, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants