Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow convex partition on clockwise polygons #901

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Mar 2, 2022

Followup to #893 (comment), made possible by x6ud/poly-partition-js#1. Thanks @x6ud!

@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 2, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9cfe22f
Status: ✅  Deploy successful!
Preview URL: https://60f48b64.penrose-panes.pages.dev

View logs

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #901 (9cfe22f) into main (c0552dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          62       62           
  Lines        8115     8117    +2     
  Branches     1767     1768    +1     
=======================================
+ Hits         5532     5534    +2     
  Misses       2576     2576           
  Partials        7        7           
Impacted Files Coverage Δ
packages/core/src/contrib/Minkowski.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0552dd...9cfe22f. Read the comment docs.

Copy link
Contributor

@jiriminarcik jiriminarcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quick! :) Thanks @samestep and @x6ud!

@samestep samestep merged commit 27a99ee into main Mar 3, 2022
@samestep samestep deleted the poly-partition-orientation branch March 3, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants