Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add semantic PR to GH Action #931

Merged
merged 4 commits into from Apr 19, 2022
Merged

ci: add semantic PR to GH Action #931

merged 4 commits into from Apr 19, 2022

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Apr 19, 2022

Description

Semantic PR's service is unstable. This PR adds a GitHub Action that does the same thing, which should be much more reliable.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 19, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: eeec346
Status: ✅  Deploy successful!
Preview URL: https://b4f01a17.penrose-panes.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #931 (eeec346) into main (9513462) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   68.15%   68.15%           
=======================================
  Files          62       62           
  Lines        8123     8123           
  Branches     1771     1771           
=======================================
  Hits         5536     5536           
  Misses       2580     2580           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9513462...eeec346. Read the comment docs.

@wodeni wodeni merged commit d2c552c into main Apr 19, 2022
@wodeni wodeni deleted the semantic-pr branch April 19, 2022 18:31
Comment on lines +4 to +8
pull_request:
types:
- opened
- edited
- synchronize
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's incorrect to have this triggered on both pull_request and pull_request_target; judging from the action's README, it seems like we should be using only pull_request_target?

Suggested change
pull_request:
types:
- opened
- edited
- synchronize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants