Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: draw command in @penrose/automator #937

Merged
merged 1 commit into from Apr 22, 2022
Merged

fix: draw command in @penrose/automator #937

merged 1 commit into from Apr 22, 2022

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Apr 22, 2022

Description

Fixes #935

The draw command in @penrose/automator calls singleProcess with the wrong arguments, notably missing variation. This PR adds an optional --variation option to the command and generate a random string for the variation seed if none is provided.

Examples with steps to reproduce them

See #935

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@wodeni wodeni requested a review from cmumatt April 22, 2022 14:42
@wodeni wodeni self-assigned this Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #937 (13383af) into main (40788cc) will not change coverage.
The diff coverage is n/a.

❗ Current head 13383af differs from pull request most recent head bd48fa2. Consider uploading reports for the commit bd48fa2 to get more accurate results

@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   68.15%   68.15%           
=======================================
  Files          62       62           
  Lines        8123     8123           
  Branches     1771     1771           
=======================================
  Hits         5536     5536           
  Misses       2580     2580           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40788cc...bd48fa2. Read the comment docs.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd48fa2
Status: ✅  Deploy successful!
Preview URL: https://97ef9eda.penrose-panes.pages.dev

View logs

@cmumatt cmumatt merged commit 261fd4c into main Apr 22, 2022
@wodeni wodeni deleted the fix-automator-draw branch May 24, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automator fails in draw mode
2 participants