fix: Make autodiff deterministic in graph shape #945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the global
count
hack leftover by #907, replacing it with an ordering on nodes according to breadth-first search and the ordering on edge labels already given by thechildren
function.Implementation strategy and design decisions
Since this PR follows #939, I used the following commands to update
diagrams/
(adapted from.github/workflows/build.yml
):cd packages/automator/ yarn start batch registry.json ../../diagrams/ --src-prefix=../examples/src/
In order to make this work correctly (without
--folders
), I made a small tweak topackages/automator/index.tsx
. I'll update our Registry wiki page after this PR is merged.Checklist
diagrams/
folder