refactor: Replace eigen with ml-matrix #954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a similar spirit to #896, this PR replaces our dependency on eigen with ml-matrix (found by @joshsunshine), which:
await
ready
stepRunning
.github/bench.sh
on ea9d7ea showed improved performance on all diagrams in our registry; running it on bd01bd0 showed improve performance on all but one (diagrams/incenter-triangle-euclidean.svg
). I'm guessing that one is just due to noise.Checklist
diagrams/
folder