Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace eigen with ml-matrix #954

Merged
merged 3 commits into from May 10, 2022
Merged

refactor: Replace eigen with ml-matrix #954

merged 3 commits into from May 10, 2022

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented May 10, 2022

Description

In a similar spirit to #896, this PR replaces our dependency on eigen with ml-matrix (found by @joshsunshine), which:

Running .github/bench.sh on ea9d7ea showed improved performance on all diagrams in our registry; running it on bd01bd0 showed improve performance on all but one (diagrams/incenter-triangle-euclidean.svg). I'm guessing that one is just due to noise.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 10, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd01bd0
Status: ✅  Deploy successful!
Preview URL: https://dfc78f50.penrose-panes.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #954 (f35474d) into main (4c428cf) will decrease coverage by 0.08%.
The diff coverage is 91.66%.

❗ Current head f35474d differs from pull request most recent head bd01bd0. Consider uploading reports for the commit bd01bd0 to get more accurate results

@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   63.19%   63.10%   -0.09%     
==========================================
  Files          62       62              
  Lines        7930     7912      -18     
  Branches     1827     1826       -1     
==========================================
- Hits         5011     4993      -18     
  Misses       2795     2795              
  Partials      124      124              
Impacted Files Coverage Δ
packages/core/src/engine/Optimizer.ts 81.41% <91.30%> (-0.75%) ⬇️
packages/core/src/index.ts 70.06% <100.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c428cf...bd01bd0. Read the comment docs.

@samestep samestep marked this pull request as ready for review May 10, 2022 01:09
@samestep samestep mentioned this pull request May 10, 2022
3 tasks
@samestep samestep merged commit d026280 into main May 10, 2022
@samestep samestep deleted the ml-matrix branch May 10, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant