Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Delete compressed graph implementation #957

Merged
merged 1 commit into from May 11, 2022

Conversation

samestep
Copy link
Collaborator

Description

This PR deletes the compressed graph representation introduced by #840, as currently it's unused and we don't have a specific use case in mind that isn't covered by graphlib. Quoting a Slack conversation with @joshsunshine:

Go ahead and delete it. We can find it again in the git history if for some reason we need it.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #957 (d5be05c) into main (aa6209f) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   63.10%   62.86%   -0.25%     
==========================================
  Files          62       62              
  Lines        7911     7857      -54     
  Branches     1826     1821       -5     
==========================================
- Hits         4992     4939      -53     
+ Misses       2795     2794       -1     
  Partials      124      124              
Impacted Files Coverage Δ
packages/core/src/utils/Graph.ts 66.12% <ø> (-14.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa6209f...d5be05c. Read the comment docs.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5be05c
Status: ✅  Deploy successful!
Preview URL: https://f8fa550d.penrose-panes.pages.dev

View logs

@samestep samestep merged commit 507ed95 into main May 11, 2022
@samestep samestep deleted the delete-compressed-graph branch May 11, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant