Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make NotTypeConsIn... into ParseError #961

Merged
merged 2 commits into from
May 12, 2022

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented May 12, 2022

Description

Previously TypeDecl's superTypes field, SubTypeDecl's subType and superType fields, and PreludeDecl's type field were Type, but compiler/Domain checked that they were actually TypeConstructor and errored otherwise. This PR puts TypeConstructor into our grammar and gets rid of the NotTypeConsInSubtype and NotTypeConsInPrelude error types.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@samestep samestep requested a review from wodeni May 12, 2022 18:50
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #961 (07ba3d1) into main (f714bbe) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 07ba3d1 differs from pull request most recent head 8b0f74f. Consider uploading reports for the commit 8b0f74f to get more accurate results

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
+ Coverage   63.03%   63.10%   +0.07%     
==========================================
  Files          62       62              
  Lines        7947     7925      -22     
  Branches     1851     1842       -9     
==========================================
- Hits         5009     5001       -8     
+ Misses       2814     2800      -14     
  Partials      124      124              
Impacted Files Coverage Δ
packages/core/src/compiler/Domain.ts 86.95% <ø> (+0.72%) ⬆️
packages/core/src/utils/Error.ts 34.72% <ø> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f714bbe...8b0f74f. Read the comment docs.

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 12, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8b0f74f
Status: ✅  Deploy successful!
Preview URL: https://c0f9246b.penrose-panes.pages.dev

View logs

@samestep samestep changed the title feat: Make NotTypeConsInSubtype into a parse error feat: Make NotTypeConsIn... into a parse error May 12, 2022
@samestep samestep changed the title feat: Make NotTypeConsIn... into a parse error feat: Make NotTypeConsIn... into ParseError May 12, 2022
@samestep samestep merged commit 047ce4b into main May 12, 2022
@samestep samestep deleted the notconsinsubtype-parse-error branch May 12, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants