Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use eqeqeq and no-template-curly-in-string #968

Merged
merged 2 commits into from May 13, 2022

Conversation

samestep
Copy link
Collaborator

Description

This PR enables the ESLint rules eqeqeq and no-template-curly-in-string at the "error" level in @penrose/core. I chose these specific ones because they both revealed some code that actually should be changed, rather than just being stylistic or not surfacing any issues in our codebase at all.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@samestep samestep requested a review from wodeni May 13, 2022 02:55
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #968 (3eb5a4e) into main (97d0e89) will increase coverage by 0.05%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
+ Coverage   63.17%   63.23%   +0.05%     
==========================================
  Files          62       62              
  Lines        7925     7918       -7     
  Branches     1843     1837       -6     
==========================================
  Hits         5007     5007              
+ Misses       2794     2790       -4     
+ Partials      124      121       -3     
Impacted Files Coverage Δ
packages/core/src/contrib/Functions.ts 13.71% <0.00%> (ø)
packages/core/src/engine/Evaluator.ts 32.98% <0.00%> (+0.59%) ⬆️
packages/core/src/renderer/AttrHelper.ts 53.61% <0.00%> (ø)
packages/core/src/contrib/Queries.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d0e89...3eb5a4e. Read the comment docs.

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3eb5a4e
Status:⚡️  Build in progress...

View logs

@samestep samestep requested a review from cmumatt May 13, 2022 15:09
Copy link
Contributor

@cmumatt cmumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we are getting errors for these now. Thanks for doing this!

@samestep samestep merged commit ea8d9f4 into main May 13, 2022
@samestep samestep deleted the eqeqeq-no-template-curly-in-string branch May 13, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants