-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Style compiler cleanup #971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
- Coverage 63.52% 63.13% -0.39%
==========================================
Files 62 62
Lines 7909 7813 -96
Branches 1830 1814 -16
==========================================
- Hits 5024 4933 -91
+ Misses 2766 2762 -4
+ Partials 119 118 -1
Continue to review full report at Codecov.
|
Removes obj/constr caching and repeated codegen
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue/PR: #888
This PR refactors multiple modules related to the Style compiler to prepare for the rewrite.
Implementation strategy and design decisions
Opt
andCompGraph
back to@penrose/browser-ui
back for debuggingStyle.ts
State
and remove unused propertiesevalFns
: the original version generates code (i.e. callsgenCode
) for every single objective and constraint. This PR adds secondary outputs that are intermediate nodes in the optimization graph. Retrieving the energy values of those functions is a matter of pulling the secondary outputs out of the graph.Examples with steps to reproduce them
This PR adds
Opt
back, which reports the energy values of individual constraints and objectives:Note that this view doesn't report the gradients for objectives. See comment here:
penrose/packages/browser-ui/src/inspector/views/Opt.tsx
Line 27 in 8d7547e
Checklist
diagrams/
folder