build: Run tsc --noEmit as prebuild for vite build #973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #866. @wodeni and I made some progress toward this in #941 and #942, but #943 seems to have caused some regression, because Vite doesn't typecheck code:
Thus, this PR adds
tsc --noEmit
as aprebuild
script before everyvite build
script (except for@penrose/components
, which seems to do something special and for whichtsc --noEmit
fails). This exposes a couple type errors caused by #906, which this PR also fixes.Checklist
diagrams/
folder