Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename VarAD to ad.Num and delete VecAD #974

Merged
merged 1 commit into from May 14, 2022
Merged

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented May 14, 2022

Description

Resolves #906 (comment) by renaming or deleting everything remaining in types/ad that had an AD suffix. Note that just like #907, this PR does not modify packages/docs-site/docs/ref/style/functions.mdx because #927 is not yet resolved.

This PR also renames two functions in engine/EngineUtils:

  • valueVarADs -> valueADNums
  • colorVarADs -> colorADNums

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #974 (a52b26a) into main (59cfdcf) will increase coverage by 0.04%.
The diff coverage is 68.48%.

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   63.41%   63.45%   +0.04%     
==========================================
  Files          62       62              
  Lines        7886     7895       +9     
  Branches     1827     1830       +3     
==========================================
+ Hits         5001     5010       +9     
  Misses       2766     2766              
  Partials      119      119              
Impacted Files Coverage Δ
packages/core/src/renderer/Staging.ts 12.50% <0.00%> (ø)
packages/core/src/shapes/Circle.ts 100.00% <ø> (ø)
packages/core/src/shapes/Ellipse.ts 100.00% <ø> (ø)
packages/core/src/shapes/Line.ts 100.00% <ø> (ø)
packages/core/src/shapes/Path.ts 100.00% <ø> (ø)
packages/core/src/shapes/Shapes.ts 100.00% <ø> (ø)
packages/core/src/shapes/Text.ts 60.00% <ø> (ø)
packages/core/src/utils/toCustomAD.ts 88.27% <ø> (ø)
packages/core/src/contrib/Functions.ts 13.60% <16.16%> (ø)
packages/core/src/contrib/Objectives.ts 17.69% <40.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59cfdcf...a52b26a. Read the comment docs.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a52b26a
Status: ✅  Deploy successful!
Preview URL: https://4f8c2522.penrose-panes.pages.dev

View logs

@samestep samestep merged commit 30090af into main May 14, 2022
@samestep samestep deleted the varad-rename branch May 14, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants