feat: Minkowski penalties for Ellipse-Ellipse #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 64.15% 64.73% +0.57%
==========================================
Files 59 59
Lines 7412 7471 +59
Branches 1675 1678 +3
==========================================
+ Hits 4755 4836 +81
+ Misses 2556 2535 -21
+ Partials 101 100 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Deploying with
|
| Latest commit: |
80e7fde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://421a43d0.penrose-72l.pages.dev |
| Branch Preview URL: | https://ellipse-ellipse.penrose-72l.pages.dev |
Co-authored-by: Sam Estep <sam@samestep.com>
Co-authored-by: Sam Estep <sam@samestep.com>
Co-authored-by: Sam Estep <sam@samestep.com>
Co-authored-by: Sam Estep <sam@samestep.com>
Co-authored-by: Sam Estep <sam@samestep.com>
Co-authored-by: Sam Estep <sam@samestep.com>
3 tasks
samestep
reviewed
Aug 22, 2022
samestep
approved these changes
Aug 25, 2022
|
Oh actually it looks like the tests are failing; I'm guessing once you fix those we should be good to merge this? |
samestep
reviewed
Nov 23, 2022
| @@ -370,7 +370,7 @@ describe("polyRoots tests", () => { | |||
| expect(gradient[2]).toBeCloseTo(-1 / 3); | |||
| }); | |||
|
|
|||
| test("quintic", () => { | |||
| test("quartic", () => { | |||
There was a problem hiding this comment.
Hey @jiriminarcik, I just noticed that you erroneously changed this test description in this PR. The polynomial is indeed quintic, since the fifth-degree coefficient is implicitly 1. I'm opening a PR to change this line back.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PR: #911
This PR implements Minkowski constraints for Ellipses using root solver from #906. It also covers penalties for Ellipse-Circle combination as a special case.
Implementation strategy and design decisions
The helper functions for computations involving implicit shapes are now in a new file
packages/core/src/contrib/ImplicitShapes.ts.Checklist
diagrams/folderOpen questions
There is only one remaining family of shapes to be covered by Minkowski penalties: Bezier curves.