Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Format On Save in VS Code #978

Merged
merged 1 commit into from May 17, 2022
Merged

Conversation

samestep
Copy link
Collaborator

Description

Previously I left this setting out of our penrose.code-workspace file because I was guessing that different people have different preferences about this, but now I think it's more likely that some people simply didn't know this setting exists.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #978 (119e33f) into main (2842be8) will not change coverage.
The diff coverage is n/a.

❗ Current head 119e33f differs from pull request most recent head 93a8e0b. Consider uploading reports for the commit 93a8e0b to get more accurate results

@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   63.39%   63.39%           
=======================================
  Files          62       62           
  Lines        7867     7867           
  Branches     1818     1818           
=======================================
  Hits         4987     4987           
  Misses       2762     2762           
  Partials      118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2842be8...93a8e0b. Read the comment docs.

Copy link
Contributor

@jiriminarcik jiriminarcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who "simply didn't know this setting exists", I approve these changes.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93a8e0b
Status: ✅  Deploy successful!
Preview URL: https://19993bad.penrose-panes.pages.dev

View logs

@samestep samestep merged commit 1172042 into main May 17, 2022
@samestep samestep deleted the vscode-formatonsave branch May 17, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants