Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editor Rewrite #992

Merged
merged 17 commits into from May 19, 2022
Merged

feat: Editor Rewrite #992

merged 17 commits into from May 19, 2022

Conversation

maxkrieger
Copy link
Member

@maxkrieger maxkrieger commented May 19, 2022

This PR replaces panes with editor. It's way better.

  • seed
  • inspector (errors in there)
  • resample

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 19, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3287130
Status:⚡️  Build in progress...

View logs

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #992 (3287130) into main (087a5ab) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   63.71%   63.71%           
=======================================
  Files          62       62           
  Lines        7789     7789           
  Branches     1782     1782           
=======================================
  Hits         4963     4963           
  Misses       2714     2714           
  Partials      112      112           
Impacted Files Coverage Δ
packages/core/src/engine/AutodiffFunctions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087a5ab...3287130. Read the comment docs.

Copy link
Collaborator

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 fix CI pls

@maxkrieger maxkrieger merged commit 91022fa into main May 19, 2022
@maxkrieger maxkrieger deleted the max/even-better-ide branch May 19, 2022 20:48
@wodeni wodeni mentioned this pull request May 27, 2022
7 tasks
@wodeni wodeni mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants