Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PDI-15453] JobEntryWaitForSQL Wrong Error Count
Belt and Suspenders due to PDI-15437 Test Cases added
- Loading branch information
Matt Tucker
committed
Jul 12, 2016
1 parent
acdcabe
commit 4ac4ac5
Showing
3 changed files
with
154 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
test/org/pentaho/di/job/entries/waitforsql/JobEntryWaitForSQLTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /*! ****************************************************************************** | ||
| * | ||
| * Pentaho Data Integration | ||
| * | ||
| * Copyright (C) 2002-2016 by Pentaho : http://www.pentaho.com | ||
| * | ||
| ******************************************************************************* | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| ******************************************************************************/ | ||
|
|
||
| package org.pentaho.di.job.entries.waitforsql; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.mockito.Matchers.any; | ||
| import static org.mockito.Matchers.anyLong; | ||
| import static org.mockito.Matchers.anyString; | ||
| import static org.mockito.Mockito.doNothing; | ||
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.spy; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import java.util.UUID; | ||
|
|
||
| import org.junit.Before; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.pentaho.di.core.KettleEnvironment; | ||
| import org.pentaho.di.core.Result; | ||
| import org.pentaho.di.core.database.DatabaseMeta; | ||
| import org.pentaho.di.core.exception.KettleException; | ||
| import org.pentaho.di.core.logging.LogChannelInterface; | ||
| import org.pentaho.di.job.Job; | ||
|
|
||
| public class JobEntryWaitForSQLTest { | ||
|
|
||
| DatabaseMeta mockDbMeta; | ||
| Job parentJob; | ||
| LogChannelInterface parentJobLogChannel; | ||
|
|
||
| @BeforeClass | ||
| public static void setUpBeforeClass() throws KettleException { | ||
| KettleEnvironment.init( false ); | ||
| } | ||
|
|
||
| @Before | ||
| public void setup() { | ||
| mockDbMeta = mock( DatabaseMeta.class ); | ||
| parentJob = spy( new Job() ); | ||
| when( parentJob.isStopped() ).thenReturn( false ); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGoodResult() throws KettleException { | ||
| JobEntryWaitForSQL entry = spy( new JobEntryWaitForSQL() ); | ||
| doReturn( true ).when( entry ).SQLDataOK( any( Result.class ), anyLong(), anyString(), anyString(), anyString() ); | ||
| doNothing().when( entry ).checkConnection(); | ||
|
|
||
| entry.setDatabase( mockDbMeta ); | ||
| entry.successCondition = JobEntryWaitForSQL.SUCCESS_CONDITION_ROWS_COUNT_GREATER; | ||
| entry.rowsCountValue = "0"; | ||
| entry.setMaximumTimeout( "1" ); // Seconds | ||
| entry.setCheckCycleTime( "1" ); // Seconds | ||
| entry.tablename = UUID.randomUUID().toString(); | ||
| entry.setParentJob( parentJob ); | ||
|
|
||
| Result result = entry.execute( new Result(), 0 ); | ||
| assertNotNull( result ); | ||
| assertTrue( result.getResult() ); | ||
| assertEquals( 0, result.getNrErrors() ); | ||
| } | ||
|
|
||
| @Test | ||
| public void testBadResult() throws KettleException { | ||
| JobEntryWaitForSQL entry = spy( new JobEntryWaitForSQL() ); | ||
| doReturn( false ).when( entry ).SQLDataOK( any( Result.class ), anyLong(), anyString(), anyString(), anyString() ); | ||
| doNothing().when( entry ).checkConnection(); | ||
|
|
||
| entry.setDatabase( mockDbMeta ); | ||
| entry.successCondition = JobEntryWaitForSQL.SUCCESS_CONDITION_ROWS_COUNT_GREATER; | ||
| entry.rowsCountValue = "0"; | ||
| entry.setMaximumTimeout( "1" ); // Seconds | ||
| entry.setCheckCycleTime( "1" ); // Seconds | ||
| entry.tablename = UUID.randomUUID().toString(); | ||
| entry.setParentJob( parentJob ); | ||
|
|
||
| Result result = entry.execute( new Result(), 0 ); | ||
| assertNotNull( result ); | ||
| assertFalse( result.getResult() ); | ||
| assertEquals( 1, result.getNrErrors() ); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSuccessOnTimeout() throws KettleException { | ||
| JobEntryWaitForSQL entry = spy( new JobEntryWaitForSQL() ); | ||
| doReturn( false ).when( entry ).SQLDataOK( any( Result.class ), anyLong(), anyString(), anyString(), anyString() ); | ||
| doNothing().when( entry ).checkConnection(); | ||
|
|
||
| entry.setDatabase( mockDbMeta ); | ||
| entry.successCondition = JobEntryWaitForSQL.SUCCESS_CONDITION_ROWS_COUNT_GREATER; | ||
| entry.rowsCountValue = "0"; | ||
| entry.setMaximumTimeout( "1" ); // Seconds | ||
| entry.setCheckCycleTime( "1" ); // Seconds | ||
| entry.tablename = UUID.randomUUID().toString(); | ||
| entry.setSuccessOnTimeout( true ); | ||
| entry.setParentJob( parentJob ); | ||
|
|
||
| Result result = entry.execute( new Result(), 0 ); | ||
| assertNotNull( result ); | ||
| assertTrue( result.getResult() ); | ||
| assertEquals( 0, result.getNrErrors() ); | ||
| } | ||
| } |