[TEST] - Fix Checkstyle violations

- rename PurRepositoryBaseTest ->PurRepositoryTestBase not to follow the pattern for tests - apply proper formatting to PurRepositoryTest - apply proper formatting to PurRepositoryTestBase
pentaho · Oct 5, 2015 · b717b5a · b717b5a
1 parent eabd9fc
commit b717b5a
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 9 deletions.
diff --git a/plugins/pdi-pur-plugin/test/org/pentaho/di/repository/pur/PurRepositoryTest.java b/plugins/pdi-pur-plugin/test/org/pentaho/di/repository/pur/PurRepositoryTest.java
@@ -27,7 +27,14 @@
 import java.io.File;
 import java.io.Serializable;
 import java.text.SimpleDateFormat;
-import java.util.*;
+import java.util.AbstractList;
+import java.util.ArrayList;
+import java.util.Calendar;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
 import java.util.concurrent.Callable;
 
 import javax.jcr.Repository;
@@ -56,7 +63,14 @@
 import org.pentaho.di.imp.rules.TransformationHasANoteImportRule;
 import org.pentaho.di.job.JobMeta;
 import org.pentaho.di.partition.PartitionSchema;
-import org.pentaho.di.repository.*;
+import org.pentaho.di.repository.IRepositoryExporter;
+import org.pentaho.di.repository.ObjectId;
+import org.pentaho.di.repository.ObjectRevision;
+import org.pentaho.di.repository.RepositoryDirectoryInterface;
+import org.pentaho.di.repository.RepositoryElementInterface;
+import org.pentaho.di.repository.RepositoryObjectType;
+import org.pentaho.di.repository.RepositoryTestBase;
+import org.pentaho.di.repository.UserInfo;
 import org.pentaho.di.repository.pur.metastore.MetaStoreTestBase;
 import org.pentaho.di.shared.SharedObjectInterface;
 import org.pentaho.di.trans.TransMeta;

diff --git a/...repository/pur/PurRepositoryBaseTest.java → ...repository/pur/PurRepositoryTestBase.java b/...repository/pur/PurRepositoryBaseTest.java → ...repository/pur/PurRepositoryTestBase.java
@@ -69,14 +69,12 @@
 /**
  * @author Andrey Khayrutdinov
  */
-@ContextConfiguration(
-  locations = {
+@ContextConfiguration( locations = {
     "classpath:/repository.spring.xml",
     "classpath:/repository-test-override.spring.xml",
-    "classpath:/pdi-pur-plugin-test-override.spring.xml"
-} )
+    "classpath:/pdi-pur-plugin-test-override.spring.xml" } )
 @RunWith( SpringJUnit4ClassRunner.class )
-public abstract class PurRepositoryBaseTest implements ApplicationContextAware {
+public abstract class PurRepositoryTestBase implements ApplicationContextAware {
 
   protected static final String TEST_LOGIN = "tester";
   protected static final String TEST_TENANT = "testTenant";

diff --git a/...ur-plugin/test/org/pentaho/di/repository/pur/PurRepository_GetObjectInformation_Test.java b/...ur-plugin/test/org/pentaho/di/repository/pur/PurRepository_GetObjectInformation_Test.java
@@ -40,7 +40,7 @@
 /**
  * @author Andrey Khayrutdinov
  */
-public class PurRepository_GetObjectInformation_Test extends PurRepositoryBaseTest {
+public class PurRepository_GetObjectInformation_Test extends PurRepositoryTestBase {
 
   @Test
   public void getObjectInformation_IsDeletedFlagSet_Job() throws Exception {

diff --git a/...s/pdi-pur-plugin/test/org/pentaho/di/repository/pur/PurRepository_MoveAndRename_Test.java b/...s/pdi-pur-plugin/test/org/pentaho/di/repository/pur/PurRepository_MoveAndRename_Test.java
@@ -33,7 +33,7 @@
 import static org.junit.Assert.assertThat;
 import static org.junit.matchers.JUnitMatchers.hasItem;
 
-public class PurRepository_MoveAndRename_Test extends PurRepositoryBaseTest {
+public class PurRepository_MoveAndRename_Test extends PurRepositoryTestBase {
 
   private final JobAssistant jobAssistant = new JobAssistant();
   private final TransAssistant transAssistant = new TransAssistant();