Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PDI-14852] setVariable in Javascript Step with scope of parent job d…
…oes not work - Refactoring (changing variable names, representing variable scopes as enums, separating logic of setting variable on different scope-levels in different methods) - Starting to climb variable-space hierarchy from the step's transformation (not from the step itself, as the first call to step's parent will lead to the transformation itself, which is not the expected behavior)
- Loading branch information
Ivan Nikolaichuk
authored and
Ivan Nikolaichuk
committed
May 18, 2016
1 parent
20f428f
commit f66b87c
Showing
3 changed files
with
388 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
...pentaho/di/trans/steps/scriptvalues_mod/ScriptValueAddFunctions_GetVariableScopeTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /*! ****************************************************************************** | ||
| * | ||
| * Pentaho Data Integration | ||
| * | ||
| * Copyright (C) 2002-2016 by Pentaho : http://www.pentaho.com | ||
| * | ||
| ******************************************************************************* | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| ******************************************************************************/ | ||
|
|
||
| package org.pentaho.di.trans.steps.scriptvalues_mod; | ||
|
|
||
| import org.junit.Test; | ||
| import org.mozilla.javascript.EvaluatorException; | ||
|
|
||
| import static junit.framework.Assert.assertEquals; | ||
|
|
||
| public class ScriptValueAddFunctions_GetVariableScopeTest { | ||
|
|
||
| @Test | ||
| public void getSystemVariableScope() { | ||
| assertEquals( ScriptValuesAddedFunctions.getVariableScope( "s" ), ScriptValuesAddedFunctions.VariableScope.SYSTEM ); | ||
| } | ||
|
|
||
| @Test | ||
| public void getRootVariableScope() { | ||
| assertEquals( ScriptValuesAddedFunctions.getVariableScope( "r" ), ScriptValuesAddedFunctions.VariableScope.ROOT ); | ||
| } | ||
|
|
||
| @Test | ||
| public void getParentVariableScope() { | ||
| assertEquals( ScriptValuesAddedFunctions.getVariableScope( "p" ), ScriptValuesAddedFunctions.VariableScope.PARENT ); | ||
| } | ||
|
|
||
| @Test | ||
| public void getGrandParentVariableScope() { | ||
| assertEquals( ScriptValuesAddedFunctions.getVariableScope( "g" ), | ||
| ScriptValuesAddedFunctions.VariableScope.GRAND_PARENT ); | ||
| } | ||
|
|
||
| @Test( expected = EvaluatorException.class ) | ||
| public void getNonExistingVariableScope() { | ||
| ScriptValuesAddedFunctions.getVariableScope( "dummy" ); | ||
| } | ||
| } |
Oops, something went wrong.