Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKLOG-16814] Base classes for input steps #4033

Merged
merged 1 commit into from
Jun 19, 2017
Merged

[BACKLOG-16814] Base classes for input steps #4033

merged 1 commit into from
Jun 19, 2017

Conversation

AlexanderBuloichik
Copy link
Contributor

No description provided.

@AlexanderBuloichik AlexanderBuloichik mentioned this pull request Jun 16, 2017
Closed
@wingman-pentaho
Copy link
Collaborator

Build Completed

❌ This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-xml-plugin/build.xml clean-all resolve jacoco && ant -f plugins/kettle-xml-plugin/build.xml checkstyle publish-local

Cleanup Commands

rm -r ~/.ivy2/local || echo no publish local to remove

Changed files

  engine/src/org/pentaho/di/trans/steps/fileinput/BaseFileInputStep.java
  engine/src/org/pentaho/di/trans/steps/fileinput/BaseFileInputStepMeta.java
  engine/src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputMeta.java
  engine/src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputReader.java
  engine/src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtils.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/BaseTextParsingTest.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputMetaNewInjectionTest.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputMetaTest.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputTest.java
  plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/xmloutput/XMLOutputMeta.java
  ui/src/org/pentaho/di/ui/trans/step/BaseFileStepDialog.java
  ui/src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileCSVImportProgressDialog.java
  ui/src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileInputDialog.java
  ui/test-src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileInputDialogTest.java

Unit test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory
  • Branch Change: + 7.14%
  • Complexity Change: + 7.69%
org.pentaho.di.core.injection.bean.BeanLevelInfo
  • Branch Change: -1.09%🔻
  • Complexity Change: -1.82%🔻
  • Instruction Change: -1.24%🔻
  • Line Change: -1.96%🔻
org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction
  • Branch Change: + 8.70%
  • Complexity Change: + 3.03%
  • Instruction Change: + .75%
  • Line Change: + .89%
org.pentaho.di.trans.steps.checksum.CheckSumMeta
  • Instruction Change: -.11%🔻
org.pentaho.di.trans.steps.datagrid.DataGridMeta
  • Instruction Change: -.09%🔻
org.pentaho.di.trans.steps.dbproc.DBProcMeta
  • Instruction Change: -.11%🔻
org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta
  • Branch Change: -.31%🔻
  • Instruction Change: -.06%🔻
  • Line Change: + .23%
  • Method Change: + 1.02%
org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta
  • Branch Change: -1.28%🔻
  • Complexity Change: -.78%🔻
  • Instruction Change: -.04%🔻
org.pentaho.di.trans.steps.fileinput.BaseFileInputStep
  • Instruction Change: -.11%🔻
org.pentaho.di.trans.steps.fileinput.text.TextFileInputMeta
  • Instruction Change: + .03%
org.pentaho.di.trans.steps.fileinput.text.TextFileInputReader
  • Instruction Change: -.07%🔻
org.pentaho.di.trans.steps.fileinput.text.TextFileInputUtils
  • Instruction Change: -.08%🔻
org.pentaho.di.trans.steps.groupby.GroupByMeta
  • Branch Change: + 5.21%
  • Complexity Change: + 5.26%
  • Instruction Change: + .14%
  • Line Change: + .37%
org.pentaho.di.trans.steps.ifnull.IfNullMeta
  • Branch Change: + 2.00%
  • Complexity Change: + 1.89%
  • Instruction Change: + .17%
org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta
  • Instruction Change: + .05%
org.pentaho.di.trans.steps.loadfileinput.LoadFileInputMeta
  • Branch Change: + .42%
  • Complexity Change: + .51%
  • Instruction Change: + .18%
  • Line Change: + .20%
org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta
  • Instruction Change: + .14%
org.pentaho.di.trans.steps.sort.SortRowsMeta
  • Instruction Change: + .08%
org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta
  • Branch Change: + 3.33%
  • Complexity Change: + 1.85%
  • Instruction Change: + .28%
org.pentaho.di.trans.steps.systemdata.SystemDataMeta
  • Branch Change: + 2.04%
  • Complexity Change: + 2.04%
  • Instruction Change: + .32%
  • Line Change: + .81%
org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta
  • Branch Change: -.53%🔻
org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta
  • Instruction Change: + .18%
org.pentaho.di.www.TransformationMap
  • Branch Change: + 9.09%
  • Complexity Change: + 6.15%
  • Instruction Change: + 10.03%
  • Line Change: + 10.00%
org.pentaho.di.ui.trans.steps.fileinput.text.TextFileInputDialog
  • Instruction Change: -.01%🔻

License header violations

❗ Copyright year is not the current year on engine/src/org/pentaho/di/trans/steps/fileinput/BaseFileInputStep.java. Found 2016. Was expecting 2017

❗ Copyright year is not the current year on engine/test-src/org/pentaho/di/trans/steps/fileinput/text/BaseTextParsingTest.java. Found 2016. Was expecting 2017

❗ Copyright year is not the current year on engine/test-src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputMetaTest.java. Found 2016. Was expecting 2017

❗ Copyright year is not the current year on ui/src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileCSVImportProgressDialog.java. Found 2016. Was expecting 2017

❗ Copyright year is not the current year on ui/test-src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileInputDialogTest.java. Found 2016. Was expecting 2017

@wingman-pentaho
Copy link
Collaborator

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-xml-plugin/build.xml clean-all resolve jacoco && ant -f plugins/kettle-xml-plugin/build.xml checkstyle publish-local

Cleanup Commands

rm -r ~/.ivy2/local || echo no publish local to remove

Changed files

  engine/src/org/pentaho/di/trans/steps/fileinput/BaseFileInputStep.java
  engine/src/org/pentaho/di/trans/steps/fileinput/BaseFileInputStepMeta.java
  engine/src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputMeta.java
  engine/src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputReader.java
  engine/src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtils.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/BaseTextParsingTest.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputMetaNewInjectionTest.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputMetaTest.java
  engine/test-src/org/pentaho/di/trans/steps/fileinput/text/TextFileInputTest.java
  plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/xmloutput/XMLOutputMeta.java
  ui/src/org/pentaho/di/ui/trans/step/BaseFileStepDialog.java
  ui/src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileCSVImportProgressDialog.java
  ui/src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileInputDialog.java
  ui/test-src/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileInputDialogTest.java

Unit test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

org.pentaho.di.core.injection.bean.BeanLevelInfo
  • Branch Change: -1.09%🔻
  • Complexity Change: -1.82%🔻
  • Instruction Change: -1.24%🔻
  • Line Change: -1.96%🔻
org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL
  • Branch Change: -.66%🔻
  • Complexity Change: -.93%🔻
  • Instruction Change: -.13%🔻
org.pentaho.di.trans.step.StepMeta
  • Branch Change: + .68%
  • Complexity Change: + .58%
  • Instruction Change: + .19%
  • Line Change: + .26%
org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta
  • Instruction Change: + .04%
org.pentaho.di.trans.steps.csvinput.CsvInputMeta
  • Instruction Change: -.05%🔻
org.pentaho.di.trans.steps.datagrid.DataGridMeta
  • Instruction Change: + .09%
org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta
  • Branch Change: -1.28%🔻
  • Complexity Change: -.78%🔻
  • Instruction Change: -.08%🔻
org.pentaho.di.trans.steps.fileinput.BaseFileInputStep
  • Instruction Change: -.11%🔻
org.pentaho.di.trans.steps.fileinput.text.TextFileInputMeta
  • Instruction Change: + .03%
org.pentaho.di.trans.steps.fileinput.text.TextFileInputReader
  • Instruction Change: -.07%🔻
org.pentaho.di.trans.steps.fileinput.text.TextFileInputUtils
  • Instruction Change: -.08%🔻
org.pentaho.di.trans.steps.groupby.GroupByMeta
  • Instruction Change: -.14%🔻
  • Line Change: -.37%🔻
org.pentaho.di.trans.steps.ifnull.IfNullMeta
  • Branch Change: -2.00%🔻
  • Complexity Change: -1.89%🔻
  • Instruction Change: -.17%🔻
org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta
  • Instruction Change: -.05%🔻
org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta
  • Branch Change: + 1.18%
  • Complexity Change: + 1.35%
org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta
  • Instruction Change: + .07%
org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta
  • Instruction Change: + .14%
org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta
  • Instruction Change: + .10%
org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta
  • Instruction Change: -.18%🔻
org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta
  • Branch Change: + 3.33%
  • Complexity Change: + 1.85%
  • Instruction Change: + .28%
org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta
  • Instruction Change: + .04%
org.pentaho.di.trans.steps.webservices.WebServiceMeta
  • Branch Change: + 1.79%
  • Complexity Change: + 1.19%
  • Instruction Change: + .07%
org.pentaho.di.www.TransformationMap
  • Branch Change: -12.50%🔻
  • Complexity Change: -7.69%🔻
  • Instruction Change: -15.52%🔻
  • Line Change: -14.62%🔻
org.pentaho.di.ui.trans.steps.fileinput.text.TextFileInputDialog
  • Instruction Change: -.01%🔻

@bmorrise bmorrise merged commit dd82086 into pentaho:master Jun 19, 2017
bmorrise pushed a commit that referenced this pull request Jun 19, 2017
Revert "[BACKLOG-16814] Base classes for input steps (#4033)"
a86da28 
This reverts commit dd82086.
@bmorrise bmorrise mentioned this pull request Jun 19, 2017
Merged
bmorrise pushed a commit that referenced this pull request Jun 19, 2017
Revert "[BACKLOG-16814] Base classes for input steps (#4033)" (#4035)
a853d42 
This reverts commit dd82086.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AlexanderBuloichik @wingman-pentaho @bmorrise