Add missing methods as need for integrating the latest version of this crate #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
87-missing-methods
branch
4 times, most recently
from
e26c88c
to
47948fa
Compare
|
can we merge this? I already upstreamed the changeset in penumbra-zone/penumbra#3806 |
|
One item still needed to close #87 for penumbra-zone/poseidon377#53 is the |
redshiftzero
approved these changes
Apr 2, 2024
redshiftzero
force-pushed
the
87-missing-methods
branch
from
4901fa3
to
5ea0e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet, but this serves as a convenient staging point for these changes.
Will eventually close #87.