-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(decaf377): bump dep #3806
Conversation
While the circuits are passing in |
There's still smoke test failures that need to be resolved. |
currently soft blocked by penumbra-zone/decaf377#91. Once that's merged, I can modify the |
There's an arkworks workstream to support 32-bit limbs (64-bit multiplier):
This PR will (maybe?) remain blocked until that work is merged. This is based on the observation that our fiat-crypto generated field impl (benchmarked in #3976 and recorded in https://docs.google.com/spreadsheets/d/1DonNNCN6-Nm3SxSpOymkGYOQi2wAK0l3_CfuDPq4vQc/edit#gid=0) is currently slower than the arkworks backends |
@redshiftzero what's the current status of this? |
will be unblocked by work-stream push in penumbra-zone/decaf377#101 |
@redshiftzero @cronokirby rebased PR, and crate deps have been updated for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
one last thing to figure out here actually is why we need the getrandom dependency added everywhere, since it's a dev dependency only of |
i.e., |
Describe your changes
Updates the
decaf377
,decaf377-rdsa
, andposeidon377
dep versionsIssue ticket number and link
References #3676 and consumes changes in #3678. unblocked by penumbra-zone/decaf377#101
Checklist before requesting a review