Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase diversifier size to 16 byte #1077

Closed
2 tasks done
Tracked by #1262
redshiftzero opened this issue Jul 8, 2022 · 0 comments
Closed
2 tasks done
Tracked by #1262

increase diversifier size to 16 byte #1077

redshiftzero opened this issue Jul 8, 2022 · 0 comments
Assignees
Labels
A-shielded-crypto Area: Cryptographic design for Penumbra's shielded transaction model

Comments

@redshiftzero
Copy link
Member

redshiftzero commented Jul 8, 2022

In #430 we added jumbled address encoding. As part of that change, we added a five byte padding (such that the f4jumble construction operates on 16 byte blocks). However, this means there is wasted space in our addresses.

This change is to:

  • remove the 5 bytes of padding in the address encoding/decoding prior to running through f4jumble
  • increase the size of the diversifier field from 11 to 16 bytes (making it a u128)

⚠️: this is a breaking change to addresses and should be coordinated with the other incoming changes that break the address format

@redshiftzero redshiftzero added the A-shielded-crypto Area: Cryptographic design for Penumbra's shielded transaction model label Jul 8, 2022
@redshiftzero redshiftzero self-assigned this Aug 8, 2022
@redshiftzero redshiftzero added this to the Testnet #26 - Hermippe milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-shielded-crypto Area: Cryptographic design for Penumbra's shielded transaction model
Projects
Development

No branches or pull requests

1 participant