New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: v2 address format #1262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(smoke test failing due to invalid addresses in allocations file) |
redshiftzero
force-pushed
the
breaking_addresses
branch
from
August 12, 2022 19:16
3961a9f
to
91f39e6
Compare
redshiftzero
force-pushed
the
breaking_addresses
branch
from
August 15, 2022 18:09
91f39e6
to
5aef947
Compare
redshiftzero
force-pushed
the
breaking_addresses
branch
from
August 15, 2022 18:47
00ac88b
to
015f93e
Compare
redshiftzero
force-pushed
the
breaking_addresses
branch
from
August 15, 2022 18:49
015f93e
to
f9639b5
Compare
@redshiftzero Galileo may need to be modified to parse the new address format; I forget exactly which regex is used. We can also yolo and find out though. |
hdevalence
reviewed
Aug 15, 2022
hdevalence
reviewed
Aug 15, 2022
hdevalence
reviewed
Aug 15, 2022
hdevalence
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!!!!!
This looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to stage the various address-breaking changes we have planned prior to mainnet:
oldparams