Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: v2 address format #1262

Merged
merged 9 commits into from Aug 16, 2022
Merged

crypto: v2 address format #1262

merged 9 commits into from Aug 16, 2022

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Aug 10, 2022

This PR is going to stage the various address-breaking changes we have planned prior to mainnet:

@redshiftzero
Copy link
Member Author

(smoke test failing due to invalid addresses in allocations file)

@redshiftzero redshiftzero temporarily deployed to smoke-test August 15, 2022 19:19 Inactive
@redshiftzero redshiftzero marked this pull request as ready for review August 15, 2022 19:36
@plaidfinch
Copy link
Collaborator

@redshiftzero Galileo may need to be modified to parse the new address format; I forget exactly which regex is used. We can also yolo and find out though.

crypto/src/note.rs Outdated Show resolved Hide resolved
Copy link
Member

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!!!!

This looks great.

@redshiftzero redshiftzero temporarily deployed to smoke-test August 16, 2022 00:48 Inactive
@redshiftzero redshiftzero merged commit c9d8810 into main Aug 16, 2022
@redshiftzero redshiftzero deleted the breaking_addresses branch August 16, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants